LGTM
extremely minor nit: there appears to be an extraneous whitespace edit in deps/npm/node_modules/request/node_modules/hawk/node_modules/cryptiles/.travis.yml

@jasnell that PR was made with git fetch --all && git rebase --whitespace=fix upstream/v0.10-staging, so that's Git's doing, not mine.

Understood :-)

@thealphanerd @Fishrock123 ... can I get another set of eyes to review this :-)

I already review and landed on v4. We likely want an update to 2.15.3 in order to fix the removal of test-legacy

Same for 0.12

/cc @othiym23

@nodejs/lts

#5988 (comment)

this one already landed on v4.x

It is missing a patch that gets rid of legacy test. @othiym23 would it make more sense to update 0.10 and 0.12 to the latest lts npm?

It's simple enough for us / me to do, but I was under the understanding that there were a rob ably no further releases for 0.10 and 0.12. The changes are pretty small.

I think that we are still going to have a release this could be in

/cc @rvagg

so it seems like the npm v2 test suite is just not working on v0.10 with make.

I installed the build of v0.10-staging locally and manually ran npm install && npm test in the npm directory. This is far from the entire unit test suite, but it is still better than nothing

Things are looking good aside from the single failure we also saw on v0.12

test/tap/outdated-symlink.js ........................ 13/14 4s
  when outdated is called linked packages should be displayed as such
  not ok Global Install format as expected
    at:
      file: test/tap/outdated-symlink.js
      line: 62
      column: 9
    stack: |
      test/tap/outdated-symlink.js:62:9
      f (node_modules/once/once.js:17:25)
      ChildProcess.<anonymous> (test/common-tap.js:58:5)
      maybeClose (child_process.js:766:16)
      Socket.<anonymous> (child_process.js:979:11)
      Pipe.close (net.js:466:12)

Again, this is a new test, and we already have this version in production without many complaints afaik.

With all of this being said I'm going to land this into v0.10-staging, but I would like to see if @nodejs/npm can let us know what is up with the broken test

LGTM

landed as 3cff81c